Skip to content

fix(chat): label queued actions that stop the running turn - #5333

Draft
leonongoing wants to merge 4 commits into
milind-soni:mainfrom
leonongoing:leon/fix-queued-stop-send-5236
Draft

leonongoing wants to merge 4 commits into
milind-soni:mainfrom
leonongoing:leon/fix-queued-stop-send-5236

Conversation

@leonongoing

@leonongoing leonongoing commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

When an engine cannot take a queued message into its running turn, the queue action stops that turn before the queue can advance. The button used to say Steer, with the interruption disclosed only in the tooltip and accessible name. The button now says Stop and send, Stop and send next for the head of a room queue, or Stop and send all for a direct queue. Live steering keeps its current labels.

This addresses the UI wording part of #5236. The stop and queue dispatch logic is unchanged; this does not resolve the report about cancellation of work delegated to other bots.

Before After
Mobile-width queue showing Steer Mobile-width queue showing Stop and send

Desktop before · Desktop after · Browser proof. Chrome rendered the real queue component with synthetic messages at 800px and 390px. The fallback labels fit both widths; this fixture does not dispatch turns.

  • The three new label assertions failed on the original component. All 71 Composer and size guard tests passed after the change.

  • pnpm lint, pnpm i18n:check, contrast and diff checks passed.

  • Full local pnpm typecheck hit the Node heap limit. Exact-head Linux validation passed full typecheck. Unfiltered pnpm test exited 1: 32,904 passed, 159 failed, 320 skipped and 3 todo across 2,561 files. Failures included Cloud and Bot Box fixtures. Broker, Electron and packaged-server commands passed when run separately. The 71 focused Composer tests above passed on that prior head. The run also found that the three new English labels left the Brazilian Portuguese pack incomplete.

  • Prior head 7a8c8575b adds Brazilian Portuguese and Traditional Chinese translations with their English source hashes. The i18n test reproduced the prior-head failure locally. With the translations, all 55 i18n and queued-composer tests passed, and all 16 locale catalogs validated. GitHub cancelled the current-head Linux full validation without a complete result. The PR remains a draft.

  • Prior head 8f91b45b1 merges upstream d83c52dd3. The source-hash conflict is resolved by retaining all upstream entries and the six hashes for the new button translations. All 106 Composer and i18n tests passed across 9 files, locale validation passed for all 16 languages, and scoped lint and the diff against main passed. Full typecheck and full test have not run on this merged head.

  • Current head 918e66550 merges upstream 237505ea6. The six queue-action translation hashes sit beside the existing queue labels, retaining the new upstream catalog entries. All 106 Composer and i18n tests passed across 9 files, locale validation passed for all 16 languages, and the diff against main passed. Full local pnpm typecheck passed on this head (Node 24.19.0, 4 GiB heap). Full pnpm test has not run on this merged head.

@vercel

vercel Bot commented Nov 10, 2026

Copy link
Copy Markdown

@leonongoing is attempting to deploy a commit to the SupaMaus Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Inconclusive 2

Failed Failed checks: 2 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Description check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant